Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getApproveTime #29

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Fix getApproveTime #29

merged 2 commits into from
Feb 8, 2024

Conversation

AlexSim93
Copy link
Owner

@AlexSim93 AlexSim93 commented Feb 7, 2024

Pull Request

Description

This PR should fix function which takes approval time. Pull requests should not be considered as approved if you have reviews with state changes requested

Related Issue(s)

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Other (please specify)

How Has This Been Tested?

I have added unit tests for different cases. Run

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • My changes generate no new warnings.
  • I have updated the documentation accordingly.

@AlexSim93 AlexSim93 merged commit 75f8ea5 into master Feb 8, 2024
1 check passed
@AlexSim93 AlexSim93 deleted the fix/approval-time branch February 8, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it necessary to compare before and after CHANGES_REQUESTED and APPROVED in getApproveTime?
1 participant