Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Don't re-synthesize credits.aleo #2510

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

[Perf] Don't re-synthesize credits.aleo #2510

wants to merge 1 commit into from

Conversation

ljedrz
Copy link
Collaborator

@ljedrz ljedrz commented Jul 1, 2024

Closes #2416.

@ljedrz ljedrz requested a review from raychu86 July 1, 2024 19:53
@raychu86 raychu86 requested a review from vicsn July 2, 2024 00:31
raychu86
raychu86 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@raychu86 raychu86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI runs successfully

raychu86
raychu86 suggested changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@raychu86 raychu86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change actually causes the test_vm_execute_and_finalize on my machine to hang and never finish. Without the change, it completes in around 8 minutes.

This should be investigated before we proceed with the changes.

@ljedrz
Copy link
Collaborator Author

ljedrz commented Jul 3, 2024

I can reproduce this; that being said, I'm not familiar with the associated plumbing so I'm not sure what the nature of the issue is.

@vicsn
Copy link
Contributor

vicsn commented Jul 4, 2024

Hmm I can't think immediately of why this would fail. However, given that this optimization is about resynthesis of proving keys in CallStack::Execute mode, its not something validators run into (who only use CallStack::CheckDeployment), so this seems very low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raychu86 raychu86 raychu86 requested changes

@vicsn vicsn Awaiting requested review from vicsn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Optimization] Inefficient fetching of credits.aleo PKs
3 participants
@ljedrz @vicsn @raychu86