-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auro-radio: Required attribute always displays radios as error #125
Comments
@ArcherScript Can you reconfirm which version of auro-radio you have installed? The current version is |
@ArcherScript Would you also be able to send a screenshot of how you are using auro-radio? It is hard to say whether this is a bug or implementation error since this is not reproducible on the docsite. |
I can share the code file of how we are implementing auro-radio. Upgrading to the aurodesignsystem version is the only thing that changed when I started running into issues. Also, I've updated the original issue to the correct version with the issues.
|
Can you tell me what |
Validated that it is initialized at "valueMissing", and updates to "valueMissing" upon selection.
Here's a code snippet of its use: <RadioGroup
name="language"
options={['English', 'Español']}
values={['en', 'es']}
bind:selected
>
<p slot="label" class="select-lang">
{$_('language_selector')}
</p>
</RadioGroup> |
During testing/bug exploration, I have created a dynamic example where radio buttons are created and inserted on JavaScript execution. I was able to reproduce the error documented in this issue and can verify that this is a valid bug. The example will be added to the docsite and when the bug fix is released. |
# [3.0.0](v2.2.2...v3.0.0) (2024-05-13) ### Bug Fixes * **required:** stop error ui in dynamic implementation [#125](#125) ([a19944a](a19944a)) ### Features * **event:** add events dispatched by validation repo ([0750f4a](0750f4a)) * **library:** add library to repo for custom component use ([d85ef20](d85ef20)) * **selected:** add optionSelected attribute to radio group [#97](#97) ([ba37820](ba37820)) * **validation:** install and use formvalidation repo ([5e4cd59](5e4cd59)) ### Performance Improvements * **error:** update error handling ([11cf71d](11cf71d)) * **validation:** update logic around validation handling [#125](#125) ([3d79361](3d79361)) ### BREAKING CHANGES * **validation:** The current validation has been removed and replaced by the auro-formvalidation repo to keep validation consistent across all form components.
Please verify the version of auro-radio you have installed
2.2.2
Please describe the bug
Reproducing the error
This issue cannot be reproduced on the Auro docsite
Expected behavior
When selecting an auro radio item it should not always highlight in red after selecting a radio item.
What browsers are you seeing the problem on?
Chrome
Additional context
Was not able to reproduce this in the docs site, however, copy pasting the "required" code example you will see the same issue. I reproduced this on both an existing project, as well as a new project.
I am unable to upgrade to
@aurodesignsystem/auro-radio
until this is fixed. I tried every version, and I still got the same issue on all versions.Before clicking:
After clicking:
Not able to reproduce on
"@alaskaairux/auro-radio": "^1.6.2"
Exit criteria
The issue can be closed once the error is corrected, or the docs have been updated to correctly represent how the required attribute should work.
The text was updated successfully, but these errors were encountered: