Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wayward bullets #208

Closed
vhenderson12 opened this issue Jun 18, 2024 · 4 comments · May be fixed by #215
Closed

Wayward bullets #208

vhenderson12 opened this issue Jun 18, 2024 · 4 comments · May be fixed by #215
Labels
auro-hyperlink Type: Bug Bug or Bug fixes

Comments

@vhenderson12
Copy link

Please verify the version of auro-nav you have installed

No response

Please describe the bug

  1. Go to "travel advisories" page
  2. View on mobile or view mobile sizing in browser
  3. The problem is in the list view that breaks into two lines
Screenshot 2024-06-18 at 1 40 33 PM

Reproducing the error

None

Expected behavior

We expect to see the bullet at the top of the list item content instead of at the bottom.

What browsers are you seeing the problem on?

Chrome, Safari

Additional context

No response

Exit criteria

We need a bulleted list of hyperlink with the bullets in the correct spot at the top of each list item when the hyperlinks break across multiple lines.
@vhenderson12 vhenderson12 added not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Jun 18, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Jun 19, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Jun 19, 2024
@Patrick-Daly-AA
Copy link

Looks like there's a bug we found in the inspector here:

Image

Will look into a fix for this in our next release of Auro-Hyperlink, as we are unsure of any knock-on effects of changing this. Most likely we are looking at exposing this as an option exposed tot he implementer.

@Patrick-Daly-AA Patrick-Daly-AA transferred this issue from AlaskaAirlines/auro-nav Jun 19, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Jun 19, 2024
@blackfalcon blackfalcon self-assigned this Jul 24, 2024
@blackfalcon blackfalcon linked a pull request Jul 24, 2024 that will close this issue
Dsande/perf/bullets/208 #215
Draft
6 tasks
@blackfalcon
Copy link
Member

@vhenderson12 can you verify what version of auro-hyperlink you have installed in your app? After some review, we have released updates in the past that addressed this situation, but I do not see the code in the reference URL listed.

@blackfalcon
Copy link
Member

Setting status to BLOCKED until we have verification on the version of the element used in this UI.

@blackfalcon blackfalcon added the Status: Blocked Progress on the issue is Blocked, immediate attention is required label Jul 24, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the Status: Blocked Progress on the issue is Blocked, immediate attention is required label Aug 19, 2024
@jordanjones243
Copy link
Contributor

After some digging, @jason-capsule42 and I uncovered that this is not an Auro bug and we will be closing this ticket. We have found a solution that we tested on the live travel advisories site by inserting this code in a <style> element and placing that into the <head> of the document:

li > * { vertical-align: text-top; }

Please see this link for reference of this fix: https://jsfiddle.net/2ma994cr/1/

@vhenderson12

@jordanjones243 jordanjones243 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auro-hyperlink Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dsande/perf/bullets/208 AlaskaAirlines/auro-hyperlink
4 participants
@blackfalcon @jordanjones243 @Patrick-Daly-AA @vhenderson12