Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update boolean to string attributes #35

Open
blackfalcon opened this issue May 17, 2021 · 1 comment
Open

Update boolean to string attributes #35

blackfalcon opened this issue May 17, 2021 · 1 comment
Labels
auro-flightline
Milestone
auro-flightline v...

Comments

@blackfalcon
Copy link
Member

blackfalcon commented May 17, 2021 •
edited by Patrick-Daly-AA
Loading

Is your feature request related to a problem? Please describe.

The current implementation of boolean values for stopover versus layover cause confusion. Because they are boolean attributes, they can be used together creating opportunities for side effects.

Describe the solution you'd like

Update the element to use the string attribute of variant to determine the version of the indicator. This can also backward compatible since there is an assumed default version.
@blackfalcon blackfalcon added help wanted Extra attention is needed, this user requires assistance to complete the work Type: Feature New Feature labels May 17, 2021
@blackfalcon blackfalcon mentioned this issue May 17, 2021
Closed
@blackfalcon blackfalcon mentioned this issue Jun 11, 2021
Closed
6 tasks
@blackfalcon blackfalcon removed the help wanted Extra attention is needed, this user requires assistance to complete the work label Jun 11, 2021
@blackfalcon blackfalcon changed the title auro-flight: update boolean to string attributes Update boolean to string attributes Aug 24, 2021
@braven112 braven112 removed the Issue label Dec 20, 2021
@blackfalcon blackfalcon self-assigned this Mar 31, 2022
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-flight May 3, 2022
@blackfalcon blackfalcon added this to the auro-flightline v2.0-rc milestone May 3, 2022
@blackfalcon blackfalcon added the not-reviewed Issue has not been reviewed by Auro team members label Jan 20, 2023
@blackfalcon blackfalcon removed their assignment Jan 20, 2023
@blackfalcon
Copy link
Member Author

There are potential redesigns for this element in the future. At such time we would choose to update the element's API.

@jason-capsule42 jason-capsule42 removed Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auro-flightline
Projects
None yet
Milestone
auro-flightline v2.1-rc
Development

No branches or pull requests
3 participants
@blackfalcon @braven112 @jason-capsule42