Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker needs a review of the Aria implementation #26

Open
jason-capsule42 opened this issue Jul 18, 2022 · 3 comments
Open

Datepicker needs a review of the Aria implementation #26

jason-capsule42 opened this issue Jul 18, 2022 · 3 comments

Comments

@jason-capsule42
Copy link
Member

General Support Request

Support request

Datepicker needs a review of the aria-role assigned and the implication that follow for all other aria attributes.

Possible Solution

I think 'application' might be appropriate. I saw that discussed elsewhere in another datepicker WC.

@jason-capsule42 jason-capsule42 added auro-datepicker not-reviewed Issue has not been reviewed by Auro team members labels Jul 18, 2022
@jason-capsule42 jason-capsule42 mentioned this issue Jul 19, 2022
6 tasks
@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes and removed not-reviewed Issue has not been reviewed by Auro team members labels Jul 19, 2022
@blackfalcon
Copy link
Member

Digging into this... I am noticing an issue with how this is expected to work. See the following screenshot.

Screen Shot 2022-07-19 at 1 46 21 PM

I feel it's not necessary to have aria-expanded on the root element. This is basically a wrapper of other elements. The auro-dropdown element already has this supported and when I do remove the code from datepicker, dropdown operates as expected. See in this screenshot there is no expanded state on datepicker, but expanded is set to true on dropdown.

Screen Shot 2022-07-19 at 2 18 15 PM

What's interesting to me is that Axe is having an issue with Rule: nested-interactive. Need to investigate.

@braven112
Copy link
Member

Let's have Anuja research this for us. Can we come up with a few examples that we could have users try to test out.

Lion Calendar, the one Photon is using, competitors in the airline industry or default html calendar

@braven112 braven112 added this to the auro-datepicker (a11y) milestone Aug 16, 2022
@blackfalcon blackfalcon added not-reviewed Issue has not been reviewed by Auro team members accessibility labels Jan 20, 2023
@Patrick-Daly-AA
Copy link

We will re-assess the validity of this issue after we address the peer dependencies across this, Auro Menu, and other components.

@settings settings bot removed the accessibility label Jan 4, 2024
@jason-capsule42 jason-capsule42 removed not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants