Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker in Angular App #146

Closed
Apsistec opened this issue Aug 28, 2023 · 4 comments · Fixed by #148
Closed

Datepicker in Angular App #146

Apsistec opened this issue Aug 28, 2023 · 4 comments · Fixed by #148
Assignees
Labels

Comments

@Apsistec
Copy link

Describe the bug

We are using most of the available auro packages for our desktop app, although we just started using auro about three weeks ago. We have been able to use most of the packages, but the datepicker is not working. The errors are:
./node_modules/@aurodesignsystem/auro-datepicker/index.js:1:0-51 - Error: Module not found: Error: Can't resolve './src/auro-calendar' in '/Users/[email protected]/Dev/RampApp/node_modules/@aurodesignsystem/auro-datepicker'

./node_modules/@aurodesignsystem/auro-datepicker/index.js:2:0-62 - Error: Module not found: Error: Can't resolve './src/auro-calendar-month' in '/Users/[email protected]/Dev/RampApp/node_modules/@aurodesignsystem/auro-datepicker'

./node_modules/@aurodesignsystem/auro-datepicker/index.js:3:0-60 - Error: Module not found: Error: Can't resolve './src/auro-calendar-cell' in '/Users/[email protected]/Dev/RampApp/node_modules/@aurodesignsystem/auro-datepicker'

./node_modules/@aurodesignsystem/auro-datepicker/index.js:4:0-55 - Error: Module not found: Error: Can't resolve './src/auro-datepicker' in '/Users/[email protected]/Dev/RampApp/node_modules/@aurodesignsystem/auro-datepicker'

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'RampApp'
  2. Install monorepo
  3. Run nx serve admin
  4. See error

Expected behavior

Expect to see modal of calendar when clicking on Form field.

Screenshots

src directory is in the root directory in other auro packages, but not in datepicker (see images)
image
image

Desktop (please complete the following information):

  • OS: [e.g. iOS] MacOS
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22]116.0.5845.110

Additional context

From what I can see the src folder is missing from the root directory, and instead it is in the dist folder; where in other packages the src folder is in the root directory and and not in the dist folder. The error says that './src/auro-several-things' can not be found, and that is b/c src does not exist in the root folder....

@Apsistec Apsistec added auro-datepicker not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Aug 28, 2023
@blackfalcon
Copy link
Member

VALIDATED: You can see the package internals here https://www.runpkg.com/?@aurodesignsystem/[email protected]/index.js

# ignore src
src/**/*

I believe that is was stated in another conversation that the bundled version didn't work either? That's confusing as we are using the @latest bundled version in the doc site. The fix is pretty straight forward, we need to update the .npmignore to be like the linked template.

https://github.com/AlaskaAirlines/WC-Generator/blob/master/template/.npmignore.temp

@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Aug 28, 2023
blackfalcon added a commit that referenced this issue Aug 29, 2023
Changes to be committed:
modified:   .npmignore
modified:   package.json
blackfalcon added a commit that referenced this issue Aug 29, 2023
Changes to be committed:
modified:   .npmignore
modified:   package.json
@blackfalcon blackfalcon linked a pull request Aug 29, 2023 that will close this issue
6 tasks
@blackfalcon
Copy link
Member

@Apsistec I have created a PR that I am hoping will address the install issue you are seeing. @jason-capsule42 if you could do a review of this update so that we can test this ASAP would be appreciated.

@Apsistec
Copy link
Author

Apsistec commented Aug 29, 2023 via email

blackfalcon added a commit that referenced this issue Aug 29, 2023
Changes to be committed:
modified:   .npmignore
modified:   package.json
blackfalcon pushed a commit that referenced this issue Aug 29, 2023
## [2.0.7](v2.0.6...v2.0.7) (2023-08-29)

### Bug Fixes

* update npm package configs [#146](#146) ([850c863](850c863))
@Apsistec
Copy link
Author

Apsistec commented Sep 6, 2023

It works, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants