Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen sharing? #10

Open
brootle opened this issue Jun 17, 2022 · 5 comments
Open

Screen sharing? #10

brootle opened this issue Jun 17, 2022 · 5 comments

Comments

@brootle
Copy link

brootle commented Jun 17, 2022

Hi! Can you, please, test and add example to documentation for screen sharing using OvenLiveKit?

It's funny, but I made it work simply by replacing ovenLivekit.getUserMedia with ovenLivekit.getDisplayMedia. As a result captured screen stream gets displayed in my video element and stream is sent to media engine. In my test scenario constrains were set to video: { width: 1280, height: 720 } and I was sharing browser tab. I am not sure if I simply got lucky that it did work and if display media is supported and what constrains should I use?

Thanks!

PS I just noticed the previous question was exactly regarding same problem and checking

function getDisplayMedia(constraints) {

but still not sure what to do with constraints and video element as I am having problems trying to share app window or entire screen

@SangwonOh
Copy link
Member

@brootle. As I mentioned in the issue below, the screen sharing feature is implemented, but needs a little more testing.

And the constraints required for screen sharing comply with the standard specifications. You can find more details below.

https://www.w3.org/TR/screen-capture/#constrainable-properties

@brootle
Copy link
Author

brootle commented Jul 26, 2022

@SangwonOh when do you think this feature will be released, and maybe some examples and test page added? I assume passing {video: true} as constraints is not enough to make it work?

@brootle
Copy link
Author

brootle commented Aug 19, 2022

@SangwonOh sorry to bother you again, but can you post minimalistic example on screen sharing somewhere in examples for this repo? From my side ovenLivekit.getDisplayMedia only worked for sharing a tab of google chrome browser, but not for entire screen or window...

@Quisi
Copy link

Quisi commented Aug 22, 2022

@brootle i am really interested in screen capture. As far as i researched we need to accomplish some basic rules (w3c working draft https://w3c.github.io/mediacapture-screen-share/) but that should be possible. it might be a tec issue to get the whole desktop/window screen from a browser app, idk.

can you give me a short walkthrou what you have done or already achived so far?

@SangwonOh
Copy link
Member

@brootle , @Quisi Hi! Long time no see. Thanks to the efforts of the OvenMediaEngine team, screen capture is now quite stable.
Please check it out at our https://space.ovenplayer.com/.

image

And the real usage of ovenLiveKit can also be found at https://github.com/AirenSoft/OvenSpace/blob/24161b33fdaf3f7cca5cdaf753069a05e8a52873/static/js/ovenspace.js#L198.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants