Request: onComplete callback

[justinmetros]

Cool plugin, thanks!

Just a thought, might be nice to have some sort of onComplete() callback once the plugin initializes and does its thing.

With multiple headers, its possible to see a flash of the default element before the appropriately styled element kicks in.

With a callback to signify midnight.js completed its task, it would be a cinch to remove any classes added to initially hide the undesired elements. Will fork if I can find some time. Thanks again!

[RobertoGonzalez]

@justinmetros If you want to do a fork, you should check out the 1.1 branch. The plugin is being refactored to support public methods (as well as cleaning up the code a bit). Callbacks are coming, so a PR would be quite welcome there (mostly to notify users when a header changes).

The main workaround for that issue is to add visibility:hidden to the header (via CSS -don't use display:none, since it'll break the plugin-) and remove it just after the $('header').midnight() call. That way the header won't flash on startup under most scenarios.

Thanks!

[justinmetros]

Great, thanks for quick reply!

Will try to get that PR in off 1.1.

In the meantime the workaround you mention is the exact solution I put in place and it gets the job done.