Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header can't have three states at once #21

Open
ethanstanfield opened this issue Oct 22, 2014 · 4 comments
Open

Header can't have three states at once #21

ethanstanfield opened this issue Oct 22, 2014 · 4 comments

Comments

@ethanstanfield
Copy link

In testing, I noticed that if the header height spans three sections, the header will glitch. For example the header is 500px tall and it enters a 250px tall section.

Section 1 - dark header
Section 2 (250px tall) - light header
Section 3 - dark header

Once the header hits Section two everything acts normal. When the bottom of the 500px tall header hits Section 3 PART of the header switches to the dark header even though it should be light still.

Is it possible for the header to have three states at one time instead of just two?

@RobertoGonzalez
Copy link
Member

Hi @ethanstanfield, We actually skipped that edge case for the first release since it would increase the complexity of the plugin (we'd need to make more copies of the header and refactor the code to make it work properly), and most headers are small enough to never hit that edge case. I'm going to mark this as a feature request for the next release and we'll see if it's viable. Thanks for the report!

@ethanstanfield
Copy link
Author

Sounds great thank you!

@johnrom
Copy link

johnrom commented May 11, 2017

checking in to see if this is on anyone's radar. found the plugin very useful, but we have some images we'd like to transition between on mobile.

@RobertoGonzalez
Copy link
Member

@johnrom Sorry, no news on that front. The best way to do this would be to support an arbitrary amount of headers and that's quite a bit of work to do. We'd love a PR with that feature though!

For most cases that require a similar effect, a usual (though quite limited) workaround is using many divs with fixed backgrounds, which a bunch of parallax plugins do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants