Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPT-13] Search: Filtering by certain combinations removes facets from the screen #565

Open
luodan01 opened this issue Feb 9, 2023 · 3 comments
Labels
Bug Something isn't working linear

Comments

@luodan01
Copy link
Contributor

luodan01 commented Feb 9, 2023

Certain facets are sometimes undisplayed as the user checks other facets, eventually reaching a point where they are unable to return to viewing the original list of mentors by unchecking the facets. Steps to replicate: starting from the full list of mentors, do the following in order

  1. check this

image

2. check this

image

Then this is the screen as seen:

image

3. uncheck 'BASF Southeast Asia'

image

'University of the Philippines' is no longer shown but still reflected under query parameters. It is not obvious how the user can return to the full list of mentors from this state. Issue seems somewhat resolved if disjunctiveFacets is removed from the code but not sure why this is the case

MPT-13

@luodan01 luodan01 added the Bug Something isn't working label Feb 9, 2023
@luodan01 luodan01 added this to the 2023 Wave milestone Feb 9, 2023
@IvanFengJK
Copy link
Contributor

IvanFengJK commented Feb 10, 2023

I have looked at the disjunctiveFacets documentation here: https://docs.elastic.co/search-ui/api/react/components/facet

Specifically the line 85 in App.tsx disjunctiveFacets: ["organisation", "school", "course_of_study"],

"Disjunctive" facets are facets that do not change when a selection is made. Meaning, all available options will remain as selectable options even after a selection is made.

This means that once we have selected "University of Philippines", the other university options will still be available and thus result in too long a list of university names and cause the option for "University of Philippines" to disappear.

If we were to remove "school" from the array, then you will not be able to select any other schools unless you unselect "University of Philippines" thus leaving the "University of Philippines" not to disappear from the filters. However, this means that you will no longer be able to filter by OR operation but filter only by the MATCH operation.

I think a cleaner solution would be to look at how is the list of the facet ordered and see if we can have the checked boxes always be placed at the top of the list of filters. I am not sure if this is possible. Will do a bit more research in this direction

@IvanFengJK
Copy link
Contributor

This problem is also stated here: elastic/app-search-javascript#24

The proposed solution of reordering the selected facet is currently not available using the API so may need to have a customized solution.

@wei2912
Copy link
Member

wei2912 commented Mar 2, 2023

Issue to be deferred till after 2023 Wave, due to high effort required.

@wei2912 wei2912 removed this from the 2023 Wave milestone Mar 7, 2023
@wei2912 wei2912 modified the milestone: 2023 Wave May 13, 2023
@wei2912 wei2912 added the linear label May 13, 2023
@wei2912 wei2912 changed the title Filtering by certain combinations removes facets from the screen [MPT-13] Filtering by certain combinations removes facets from the screen May 13, 2023
@wei2912 wei2912 changed the title [MPT-13] Filtering by certain combinations removes facets from the screen [MPT-13] Search: Filtering by certain combinations removes facets from the screen Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working linear
Projects
Development

No branches or pull requests

3 participants