Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing #102

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Indexing #102

wants to merge 22 commits into from

Conversation

briantoby
Copy link
Collaborator

Summarizing changes so far in this branch

GSASIIdataGUI.py

  • make sure initialization of self.HKL (G2frame.HKL) is to np.array([])
    (I saw an error where plotting failed due to trying to perform G2frame.HKL.T on a list)
  • Clear status bar before display of data tree items
    (prevents stale msgs from persisting)
  • Move plotting into UpdateUnitCellsGrid

GSASIIpwdGUI.py

  • initialization of G2frame.HKL always as np.array()
  • OnTryAll: avoid error if OnHklShow returns an empty list or ssopt['SgResults'] is empty
  • onHklShow: extensive comments; move SetItemPyData(...peaks) to where peaks is changed
  • lines 6088 to 6594: extensive GUI reorg
  • 6608: end UpdateUnitCells with a call to OnHklShow
    so that that the displayed cell/sym is what is shown on plot

GSASIIpwdplot.py

  • more comments
  • 2448-2456: even if there are no peaks, still show reflections

@briantoby
Copy link
Collaborator Author

This work is intended to address #44 but is paused as Bob has been working on the same things.

@briantoby briantoby linked an issue Nov 16, 2024 that may be closed by this pull request
briantoby and others added 7 commits November 17, 2024 20:56
…UI & histogram code in GSASIIdataGUI to use above; Needs more work to avoid 2 sets of scroll bars (for example in Reflections List)
…on Data tab. Now starts in last import directory.
…, but minor chnages to PDWR improves things (see #101)
…ions & scrolling

adaptations into the test branch to work on the indexing page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistencies in reflection generation
2 participants