Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-scrolled section of G2frame.dataWindow #101

Closed
briantoby opened this issue Nov 13, 2024 · 3 comments
Closed

non-scrolled section of G2frame.dataWindow #101

briantoby opened this issue Nov 13, 2024 · 3 comments
Assignees
@briantoby
Labels
enhancement New feature or request In progress this is being addressed but is not complete

Comments

@briantoby
Copy link
Collaborator

The data window would be a bit more clear if the top line(s) and help button were not scrolled. Perhaps GSASIIdataGUI.G2DataWindow could be reorganized to put a sizer above the scrolled region. Try in Unit Cells List?
@briantoby briantoby added enhancement New feature or request Someday... Problem noted, but will not be addressed right now. labels Nov 13, 2024
@briantoby briantoby self-assigned this Nov 20, 2024
@briantoby briantoby added In progress this is being addressed but is not complete and removed Someday... Problem noted, but will not be addressed right now. labels Nov 20, 2024
@briantoby
Copy link
Collaborator Author

briantoby commented Nov 20, 2024 •
edited
Loading

it works nicely, see c6ab63a, but a bit more work would be nice on windows that have internal scrollbars (for example Reflection Lists) where two sets of scroll bars are seen. The inner set might be the preferred set.

briantoby added a commit that referenced this issue Nov 21, 2024
@briantoby
Unscrolled regions work; reworked scrolling; Old code works as before…
d98457c 
…, but minor chnages to PDWR improves things (see #101)
@briantoby
Copy link
Collaborator Author

Done: created unscrolled regions in dataWindow and fixed up scrolling.

Old dataWindows GUI code seems to work fine (looked at main tree entries & phases), but relatively minor changes to GUI code really improves scrolling & makes help button more obvious.

Would be worthwhile to slowly revisit other GUI routines to update to use topBox for help, etc.

@briantoby
Copy link
Collaborator Author

merged into the indexing branch #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briantoby briantoby

Labels
enhancement New feature or request In progress this is being addressed but is not complete
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

topbox AdvancedPhotonSource/GSAS-II
1 participant
@briantoby