Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In OAuth guide, update the "Write a helper function for XHR requests" helper #100

Open
ashryanbeats opened this issue Oct 11, 2018 · 2 comments
Open

In OAuth guide, update the "Write a helper function for XHR requests" helper #100

ashryanbeats opened this issue Oct 11, 2018 · 2 comments
Assignees
@dkstevekwak
Labels
post-launch

Comments

@ashryanbeats
Copy link
Member

Submit an issue

Description of the issue

Use async/await
@dkstevekwak
Copy link
Contributor

@ashryanbeats can you elaborate on this for me? Currently, the helper function itself returns a promise object which is used with async/await. Since the helper function has to use XHR and its polling mechanism, the current state is the simplest we can get. Please let me know if you disagree

@dkstevekwak
Copy link
Contributor

@ashryanbeats can you look at the comments above please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkstevekwak dkstevekwak

Labels
post-launch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashryanbeats @dkstevekwak