feat: add json schema validation to aglintrc.json file for autocompletion #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royhadad
commented
Jul 1, 2024
| @@ -2,6 +2,8 @@ | |||
| .DS_Store | |||
| .eslintcache | |||
| .vscode | |||
| .idea | |||
There was a problem hiding this comment.
ignore InteliJ IDEA configuration files
royhadad
commented
Jul 1, 2024
| @@ -68,6 +68,7 @@ | |||
| "@types/text-table": "^0.2.2", | |||
| "@typescript-eslint/eslint-plugin": "^5.60.1", | |||
| "@typescript-eslint/parser": "^5.60.1", | |||
| "ajv": "^8.16.0", | |||
royhadad
commented
Jul 1, 2024
| @@ -84,15 +86,30 @@ describe('Linter config', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('check custom Superstruct validation', () => { | |||
| const assertSuperStruct = (value: unknown) => { | |||
There was a problem hiding this comment.
running the tests both on superstruct and the json schema, because they are duplicated.
In the future, we could migrate from Superstruct to Zod and automatically convert it to json schema using zod-to-json-schema, as @scripthunter7 suggested in AdguardTeam/VscodeAdblockSyntax#136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210
After this is approved, the next step would be to add it to schema store in this file.