Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new rule to validate TLDs #203

Open
scripthunter7 opened this issue Feb 6, 2024 · 2 comments
Open

Add a new rule to validate TLDs #203

scripthunter7 opened this issue Feb 6, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request Priority: P4 T: Linter rule Linter rule related

Comments

@scripthunter7
Copy link
Member

We already have a basic domain validator in AGTree. This is used to validate the domain list of the cosmetic rule or the value of the $domain modifier.

I recommend improving this utility by checking TLDs (if the TLD is not a wildcard, like example.*)

References:

@scripthunter7 scripthunter7 added enhancement New feature or request T: Linter rule Linter rule related labels Feb 6, 2024
@Alex-302
Copy link
Member

Alex-302 commented Feb 7, 2024

Maybe related to this issue - file extensions, used on the sites (to not consider as TLD)
AdguardTeam/HostlistCompiler#44

@scripthunter7
Copy link
Member Author

@Alex-302 Yes, that issue can be solved with the list of known TLDs

@scripthunter7 scripthunter7 changed the title Validate TLDs Add a new rule to validate TLDs Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: P4 T: Linter rule Linter rule related
Projects
None yet
Development

No branches or pull requests

4 participants