Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: creating zip of workspace root tries to save outside of workspace #43

Open
AdamRaichu opened this issue Apr 18, 2023 · 0 comments
Open
Labels
bug Something isn't working confirmed This issue has been confirmed by testing good first issue Good for newcomers

Comments

@AdamRaichu
Copy link
Owner

Describe the bug
Creating a zip of the workspace root (either through right-clicking the area of the explorer view that does not contain any files, or through the command interface) causes the extension to attempt to save to a location that is outside the current workspace.

To Reproduce
Steps to reproduce the behavior:

  1. Open a repo in vscode.dev.
  2. Right click the explorer view within the area shown (see screenshot).
  3. Select Zip Tools: Create a zip file from folder.
  4. Extension status bars hangs at Saving... and loads indefinitely. Console shows error (below).

Expected behavior
The extension should not try to write outside of the workspace but should instead show an error. Perhaps it could also ask if the user would like to save it to the workspace root instead.

Screenshots
If applicable, add screenshots to help explain your problem.

image

Environment
What type of VS Code were you using when you encountered the problem?

vscode.dev

Additional context
Add any other context about the problem here.

[Extension Host] Error (FileSystemError): Unable to write file 'vscode-vfs://github/AdamRaichu/vscode-extensions.zip' (AdamRaichu/undefined: Request failed due to following response errors:
 - Could not resolve to a Repository with the name 'AdamRaichu/undefined'.)
    at Function.c (../../../vs/workbench/api/worker/extensionHostWorker.js:82:27160)
    at Object.writeFile (../../../vs/workbench/api/worker/extensionHostWorker.js:82:25814)
@AdamRaichu AdamRaichu added bug Something isn't working good first issue Good for newcomers confirmed This issue has been confirmed by testing labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This issue has been confirmed by testing good first issue Good for newcomers
Projects
Development

No branches or pull requests

1 participant