Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify nif functions checking the -nifs(…) attribute #204

Open
elbrujohalcon opened this issue Jan 30, 2023 · 0 comments
Open

Identify nif functions checking the -nifs(…) attribute #204

elbrujohalcon opened this issue Jan 30, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@elbrujohalcon
Copy link
Collaborator

OTP25 introduced a new attribute to identify functions overridden by nifs: -nifs(…)..
Hank currently identifies them by their calls to erlang:nif_error/2.

Describe the solution you'd like

I would like Hank to stop inferring which functions are overridden by nifs and just use -nifs(…) to figure that out.

Describe alternatives you've considered

Hank might keep also inferring the overrides by checking erlang:nif_error/2 but I think it's better to enforce good practices and get devs to include -nifs(…) in their modules, even if they just do it to silence Hank's warnings.

@elbrujohalcon elbrujohalcon added the enhancement New feature or request label Jan 30, 2023
@elbrujohalcon elbrujohalcon added this to the 1.4.2 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant