-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supports_statement_cache support #4
Comments
Had to set attribute in each sub class as HasCacheKey._generate_cache_attrs() only checks the sub-class dict for `supports_statement_cache` attribute.
Current code states no caching support, to avoid warning. |
@clach04 Is there still work that needs to be done here? For what it's worth, I ran sa_orm_demo.py using sqlalchemy-ingres |
@hab6 I think this depends on one's perspective, is this issue for:
I've been mentally treating this ticket as both; 1 is resolved but 2 is outstanding - but that may not be super clear from current write-up/description. I vote for keeping this ticket open until we tackle number 2. Alternative would be to close and open/link a new ticket for actual caching support and update the title to explicitly mention warnings. What are your thoughts on this? |
@clach04 Thanks for the clarification. I am in agreement to keep the ticket open with the remaining goal of implementing caching support, which is not something I have looked into at this point. |
Seeing https://docs.sqlalchemy.org/en/14/errors.html#error-cprf
The text was updated successfully, but these errors were encountered: