Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend shouldn't be able to rug NFTs #21

Open
amiller opened this issue Oct 7, 2024 · 0 comments
Open

frontend shouldn't be able to rug NFTs #21

amiller opened this issue Oct 7, 2024 · 0 comments
Labels
enhancement New feature or request reliability

Comments

@amiller
Copy link
Contributor

amiller commented Oct 7, 2024

Right now although the Frontend is considered untrusted, the security guarantees aren't so ambitious. The Frontend can't misuse the oauth credentials directly (and cannot for example mint more teleports), but since the frontend receives all the NFT IDs (one time redeem codes), so it can spend any tokens minted.

It would be great to remove this. However, it's also really useful to be able to log in again from a different browser and see the inventory of Teleports URLs you have available to share.

So, a good strategy could be for the blockchain to include encrypted NFT IDs, so as long you can get a viewing key in a logged-in browser session (perhaps derived from a signature on a message using the Sign In With Ethereum, dunno) then you should be able to enumerate your inventory

@amiller amiller added the enhancement New feature or request label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reliability
Projects
None yet
Development

No branches or pull requests

1 participant