Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False log info when running with test #69

Open
theikalman opened this issue Jun 13, 2023 · 0 comments · May be fixed by #70
Open

False log info when running with test #69

theikalman opened this issue Jun 13, 2023 · 0 comments · May be fixed by #70

Comments

@theikalman
Copy link

theikalman commented Jun 13, 2023 •
edited
Loading

https://github.com/AccelByte/go-restful-plugins/blob/8d98427b051c677ea4b13e8f83a8591cb28d630a/pkg/response/response.go#LL90C31-L90C31

If we run the unit test with -v that fmt.Println will be printed. And in that case it is printed an error with stacktrace similar to panic error in Go (example in the image below).

image

I suggested to remove that print to avoid confusion between panic error and normal error and instead use standar error message to print out information needed.
theikalman added a commit to theikalman/go-restful-plugins that referenced this issue Jun 13, 2023
@theikalman
remove print error stack trace to avid confusion between panic error …
3bfe653 
…and a normal error in test

fixes AccelByte#69
@theikalman theikalman linked a pull request Jun 13, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@theikalman