Implement clean up actions

[stevefan1999-personal]

It seems like the k3d cluster was not destroyed post action. This means things lie https://github.com/nektos/act cannot operator correctly without manually deleting the existing nodes.

[kuritka]

Thx @stevefan1999-personal. Can you please send me more information. Maybe create some simplified example where nodes are not deleted ?

[stevefan1999-personal]

@kuritka Just run a simple k3d-action example with https://github.com/nektos/act and run it again. The action will fail with existing cluster error which it is still indeed in Docker

[kuritka]

How about deleting the container and recreating a new one for each workflow run, rather than maintaining the state of one existing container ?

[stevefan1999-personal]

How about deleting the container and recreating a new one for each workflow run, rather than maintaining the state of one existing container ?

At least https://github.com/nektos/act doesn't because it run bare docker run behind the scene, and act doesn't manage the external state of k3d.

Maybe it works with official Github Actions which runs in an isolated VM environment that will ultimately be destroyed forcefully after each run, but this is not the case for act.

And if you look at https://github.com/helm/kind-action/tree/main, they also have clean up phase which I think is reasonable.

[kuritka]

@somaritane , @jkremser Guys, if you have any suggestions, or tou like to oppose, let us know here. PR already exists. For me it's not a bad idea, I wrote some comments on the PR.