Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor grace containers as "normal" containers (rather than attached to leaves) #1125

Open
trevorbaca opened this issue Sep 5, 2019 · 0 comments
Open

Refactor grace containers as "normal" containers (rather than attached to leaves) #1125

trevorbaca opened this issue Sep 5, 2019 · 0 comments
Assignees
@trevorbaca
Labels
refactor
Milestone
4.0

Comments

@trevorbaca
Copy link
Member

trevorbaca commented Sep 5, 2019 •
edited
Loading

This will finally fix the remaining grace iteration corner cases.
@trevorbaca trevorbaca self-assigned this Sep 5, 2019
@trevorbaca trevorbaca added this to the 4.0 milestone Oct 12, 2022
trevorbaca added a commit that referenced this issue Feb 8, 2024
@trevorbaca
Added abjad.IndependentAfterGraceContainer. Tag #1125.
3a12014
trevorbaca added a commit that referenced this issue Mar 28, 2024
@trevorbaca
Added abjad.IndependentAfterGraceContainer. Tag #1125.
f2200b7 
CHANGED. Cleaned up abjad.spanners.glissando() overrides.

    OLD: abjad.glissando() included spurious blocks like this on
    length-2 glissandi; these settings did nothing:

        \hide NoteHead
        \override Accidental.stencil = ##f
        \override NoteColumn.glissando-skip = ##t
        \override NoteHead.no-ledgers = ##t
        \revert Accidental.stencil
        \revert NoteColumn.glissando-skip
        \revert NoteHead.no-ledgers
        \undo \hide NoteHead

    NEW: abjad.glissando() no longer includes these blocks on length-2
    glissandi.

    REMOVED. Removed abjad.spanners.glissando(..., style=None) keyword.

        OLD: abjad.spanners.glissand(..., style="trill")
        NEW: Use abjad.Tweak(r"- \tweak style #'trill")

Makefile update: changed "make pytest" to "pytest tests". Newer versions
of pytest (eg, 8.1.1) error on "pytest ." because of duplicate
conftest.py, conf.py files in the abjad/abjad and abjad/tests.

    OLD: "make pytest" defined equal to "pytest ."
    NEW: "make pytest" defined equal to "pytest tests"
trevorbaca added a commit that referenced this issue Mar 28, 2024
@trevorbaca
Added abjad.IndependentAfterGraceContainer. Tag #1125.
d237dc6 
CHANGED. Cleaned up abjad.spanners.glissando() overrides.

    OLD: abjad.glissando() included spurious blocks like this on
    length-2 glissandi; these settings did nothing:

        \hide NoteHead
        \override Accidental.stencil = ##f
        \override NoteColumn.glissando-skip = ##t
        \override NoteHead.no-ledgers = ##t
        \revert Accidental.stencil
        \revert NoteColumn.glissando-skip
        \revert NoteHead.no-ledgers
        \undo \hide NoteHead

    NEW: abjad.glissando() no longer includes these blocks on length-2
    glissandi.

    REMOVED. Removed abjad.spanners.glissando(..., style=None) keyword.

        OLD: abjad.spanners.glissand(..., style="trill")
        NEW: Use abjad.Tweak(r"- \tweak style #'trill")

Makefile update: changed "make pytest" to "pytest tests". Newer versions
of pytest (eg, 8.1.1) error on "pytest ." because of duplicate
conftest.py, conf.py files in the abjad/abjad and abjad/tests.

    OLD: "make pytest" defined equal to "pytest ."
    NEW: "make pytest" defined equal to "pytest tests"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevorbaca trevorbaca

Labels
refactor
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@trevorbaca