You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In our code we use the Sepha Package.
Currently, the different implementations of the addPayment method declare that they throw an SephpaInputException (ie SepaDirectDebit00800102::addPayment() throws a SephaInputException);
However, the interface SepaPaymentCollection in SepaPaymentCollection.php does not declare this.
Therefore when creating a collection usingphp $directDebit = new SephpaDirectDebit($initgPty, $msgId, SephpaDirectDebit::SEPA_PAIN_008_001_02); Then adding a collection and calling ->addPayment on that collection does not warn you that it throws an error. Therefore your editor also thinks that try { $collection->addPayment([ ]); } catch (SephpaInputException $e) { } is redundant.
It would be nice if the interface also declares the '@ throws' in the php doc comment, as all implementations can throw it.
The text was updated successfully, but these errors were encountered:
In our code we use the Sepha Package.
Currently, the different implementations of the addPayment method declare that they throw an SephpaInputException (ie SepaDirectDebit00800102::addPayment() throws a SephaInputException);
However, the interface SepaPaymentCollection in SepaPaymentCollection.php does not declare this.
Therefore when creating a collection using
php $directDebit = new SephpaDirectDebit($initgPty, $msgId, SephpaDirectDebit::SEPA_PAIN_008_001_02);
Then adding a collection and calling ->addPayment on that collection does not warn you that it throws an error. Therefore your editor also thinks thattry { $collection->addPayment([ ]); } catch (SephpaInputException $e) { }
is redundant.It would be nice if the interface also declares the '@ throws' in the php doc comment, as all implementations can throw it.
The text was updated successfully, but these errors were encountered: