Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/fix edit command index #158

Conversation

dominic2412
Copy link

@dominic2412 dominic2412 commented Nov 5, 2024

close #125
Fix edit command to display format message when no index is given, and when only have index prompt the user to key in at least one change
image
when index is wrong, user are prompted to look at the list of valid candidates

image
when the index is correct but no field, another customised message comes out
"At least one field to edit must be provided."

image

…d when only have index prompt the user to key in at least one chanege
…d when only have index prompt the user to key in at least one chanege
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/address/logic/Messages.java 91.66% <ø> (ø) 3.00 <0.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 97.27% <ø> (ø) 13.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 96.07% <100.00%> (-0.08%) 16.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 98.36% <ø> (ø) 24.00 <0.00> (ø)

... and 7 files with indirect coverage changes

…d when only have index prompt the user to key in at least one chanege
@dominic2412 dominic2412 self-assigned this Nov 5, 2024
@dominic2412 dominic2412 added the bug Something isn't working label Nov 5, 2024
@stanleytangzh stanleytangzh merged commit 163a9e1 into AY2425S1-CS2103T-T09-2:master Nov 6, 2024
4 checks passed
Copy link

@stanleytangzh stanleytangzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Edit command index error message
2 participants