-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add temperature #66
Add temperature #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are making temperature is a new attribute of Student right? Are we intending to store more than one temperature? Since initially we had discussed to have weekly display of information.
Other than that I think the code is well written!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can consider modifying the storage such that it will track all temperature allocated to the student! cause it looks like this will be an attribute of the student that is only able to track its current temperature.
alternatively, we can modifying our requireents such that the form teacher can consider tracking daily attributes of the student
Yes indeed! I think what we can do it to create a list of students with the same attributes, but setting the temperature and attendance to null for every new day, then the teacher can just set the temperatures and attendance accordingly every day since that is what a teacher does. The weekly display of temperatures or attendance I have not thought much of it yet, but I think this could work. What do you think? Thank you for your kind words! |
Yes, I agree! I have not yet modified the storage to keep track of the weekly details of the students, but only the daily version. I will keep that in mind! Yes, I agree with the alternative too! That was the idea I mentioned in @jerrenss comment. I think we can make some of the attributes such as name, email etc static, and set the temperature and attendance to null every new day so that the teacher can update those information accordingly. What do you think? |
Great idea! This idea sounds good to me! |
Looks good to merge! Good job circle fish! |
Added temperature attribute to Student.