Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temperature #66

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Conversation

Yuanyu97
Copy link

Added temperature attribute to Student.

Copy link

@jerrenss jerrenss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are making temperature is a new attribute of Student right? Are we intending to store more than one temperature? Since initially we had discussed to have weekly display of information.

Other than that I think the code is well written!

Copy link

@gsyndromes gsyndromes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can consider modifying the storage such that it will track all temperature allocated to the student! cause it looks like this will be an attribute of the student that is only able to track its current temperature.

alternatively, we can modifying our requireents such that the form teacher can consider tracking daily attributes of the student

@Yuanyu97
Copy link
Author

You are making temperature is a new attribute of Student right? Are we intending to store more than one temperature? Since initially we had discussed to have weekly display of information.

Other than that I think the code is well written!

Yes indeed! I think what we can do it to create a list of students with the same attributes, but setting the temperature and attendance to null for every new day, then the teacher can just set the temperatures and attendance accordingly every day since that is what a teacher does. The weekly display of temperatures or attendance I have not thought much of it yet, but I think this could work. What do you think? Thank you for your kind words!

@Yuanyu97
Copy link
Author

can consider modifying the storage such that it will track all temperature allocated to the student! cause it looks like this will be an attribute of the student that is only able to track its current temperature.

alternatively, we can modifying our requireents such that the form teacher can consider tracking daily attributes of the student

Yes, I agree! I have not yet modified the storage to keep track of the weekly details of the students, but only the daily version. I will keep that in mind!

Yes, I agree with the alternative too! That was the idea I mentioned in @jerrenss comment. I think we can make some of the attributes such as name, email etc static, and set the temperature and attendance to null every new day so that the teacher can update those information accordingly. What do you think?

@gsyndromes
Copy link

gsyndromes commented Mar 10, 2020

can consider modifying the storage such that it will track all temperature allocated to the student! cause it looks like this will be an attribute of the student that is only able to track its current temperature.
alternatively, we can modifying our requireents such that the form teacher can consider tracking daily attributes of the student

Yes, I agree! I have not yet modified the storage to keep track of the weekly details of the students, but only the daily version. I will keep that in mind!

Yes, I agree with the alternative too! That was the idea I mentioned in @jerrenss comment. I think we can make some of the attributes such as name, email etc static, and set the temperature and attendance to null every new day so that the teacher can update those information accordingly. What do you think?

Great idea! This idea sounds good to me!

@TheElectricBlender
Copy link

Looks good to merge! Good job circle fish!

@TheElectricBlender TheElectricBlender added priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new labels Mar 10, 2020
@Yuanyu97 Yuanyu97 merged commit 761b293 into AY1920S2-CS2103T-W12-2:master Mar 10, 2020
@Yuanyu97 Yuanyu97 deleted the add-temperature branch March 17, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
4 participants