Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging support #8

Closed
matthewfeickert opened this issue Dec 4, 2024 · 1 comment · Fixed by #9
Closed

Add packaging support #8

matthewfeickert opened this issue Dec 4, 2024 · 1 comment · Fixed by #9

Comments

@matthewfeickert
Copy link
Contributor

Though umnn is on PyPI (https://pypi.org/project/UMNN/) it doesn't have matching packaging support in this repository, which as far as I can tell from inspecting the v1.70 sdist is the source of the PyPI distribution.

Supporting valid packaging would be important to support other packages that want to build off of umnn as well as package on conda-forge.


Related issues:

@matthewfeickert
Copy link
Contributor Author

(Double posting between here and email). Thanks very much for the fast review, @AWehenkel! If it is possible to get a new patch release of UMNN (which would require bumping the corresponding version number in

version = "1.70"
) on PyPI I can then get UMNN up on conda-forge.

As you're the project creator I would be happy to add you as a maintainer of the UMNN conda-forge feedstock, though with no expectation that you'd be responsible for reviewing any automated maintenance of it. I can fully appreciate though that having "yet one more thing" tied to your GitHub might not be desirable. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant