Order of annotation sets in tag detail pages #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdendotlol
requested changes
Dec 23, 2024
src/utils/tags.ts
Outdated
| const event_a = events.find((ev: any) => ev.id == a.data.event_id); | ||
| const event_b = events.find((ev: any) => ev.id == b.data.event_id); | ||
| if (event_a && event_b) { | ||
| return event_a.data.label < event_b.data.label |
There was a problem hiding this comment.
Comparing strings with < and > is case-sensitive:
const letters = ['A', 'a', 'B', 'z', 'Z']
console.log(letters.sort())
// ["A", "B", "Z", "a", "z"]
console.log('a' > 'b') // false
console.log('a' > 'B') // trueConverting the labels to lowercase before comparing would prevent unexpected sorting behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Quick and dirty fix for the fact that annotations sets are being displayed in an apparently nonsensical order on the various tag detail pages. This fix should have them ordered alphabetically by event label and then alphabetically by set name.