Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index page player doesn't work #100

Open
absempere opened this issue Nov 11, 2024 · 4 comments
Open

Index page player doesn't work #100

absempere opened this issue Nov 11, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@absempere
Copy link

I do not see a player on my index pages. Tanya sees the player; however, hitting play doesn't do anything.

@absempere absempere added the bug Something isn't working label Nov 11, 2024
@camdendotlol
Copy link
Contributor

Which project is this on?

@absempere
Copy link
Author

@camdendotlol https://tanyaclement.github.io/znh-1939/tags/detail/speaker/library_of_congress/

There's also an issue with the tag -- the visualization shows that the tag only appears at the end of the recording, but it appears earlier in the actual annotation set: https://tanyaclement.github.io/znh-1939/events/field-recordings-t86-243/

Also, I'm getting the player now, but clicking the annotations doesn't link us to the annotations below. get us to play, etc.

@camdendotlol
Copy link
Contributor

I wonder if this might be a UX thing. Clicking the icon next to an event's name will cause its player to appear at the bottom of the list, but it doesn't automatically start playing. You then have to go down to the player (which might involve scrolling down if there are a lot of events) and hit play to start it.

Since the button next to the names looks like a play button, maybe we should change it to something else.

@absempere
Copy link
Author

I think the expectation is that when you click an annotation on the visualization, it takes you to the annotation below? Basically that there's some connection between the visualization and the player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants