Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player is not being rendered correctly for no URL files. #221

Open
absempere opened this issue Dec 18, 2024 · 3 comments
Open

Player is not being rendered correctly for no URL files. #221

absempere opened this issue Dec 18, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@absempere
Copy link

absempere commented Dec 18, 2024

If you take a look at this project, there are 3 AV files in the Event.

Screenshot 2024-12-18 at 2 38 34 PM

The first and third events don't have AV file URLs, so the durations are nonsense values. The second file has an AV file URL and an accurate duration.

The player is showing the duration of the 2nd AV file no matter which file is selected.

Could the player be hidden if there's no AV URL associated with it? If not, can we show a duration of "00" on the player for no AV files?

Screenshot 2024-12-18 at 2 44 02 PM
@absempere absempere added the bug Something isn't working label Dec 18, 2024
@camdendotlol
Copy link
Contributor

It would be simple to hide the player when there's no URL for the current file, but the rest of the UI implies that you can play all of them so it might appear to the user that the player just broke. Ideally we'd reach out to Chelsea for ideas on how the UI should look when some AV files are offline.

Side note: My understanding is that durations are required by the manifest spec, so there should never be nonsense durations.

@tanyaclement
Copy link

I think that it would be useful to not have the durations next to the names of the files on the top. The duration is already on the player.

@absempere
Copy link
Author

absempere commented Dec 19, 2024

@ajolipa Durations are required as part of the import process, so we're entering random values to make the process work on no_URL files.
Let's

  • hide durations on the AV files because some are misleading while others are redundant
  • hide the player on no_URL files. Chelsea suggests text that says the AV file is offline so that the page doesn't look broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants