Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate a submodule to run pankti-generated test cases #22

Open
gluckzhang opened this issue Sep 24, 2020 · 1 comment
Open

generate a submodule to run pankti-generated test cases #22

gluckzhang opened this issue Sep 24, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@gluckzhang
Copy link
Member

gluckzhang commented Sep 24, 2020

We may generate a submodule that contains all the pankti-generated test cases. The benefits of doing so include:

  • A good separation between original test cases and pankti-generated
  • Only Test*PanktiGen.java and object-data.xml need to be copied to the submodule, because this module depends on all the original submodules
  • No need to modify original pom files, because only this module needs xstream as a dependency

This is an example that I manually did for TTorrent: https://github.com/gluckzhang/ttorrent/tree/ttorrent-2.0-pankti

What I did in this example:

cd path/to/pankti/pankti-generate/output/generated/ttorrent
find . -type f -name "Test*PanktiGen.java" -exec cp --parents {} path/to/ttorrent/pankti-tests/src/test/java \;
cp *.xml path/to/ttorrent/pankti-tests/src/test/resources

This is for the convenience of our experiments. At last we might still put the generated test cases in the original submodules to create a PR.

@gluckzhang gluckzhang added the enhancement New feature or request label Sep 24, 2020
@Deee92
Copy link
Contributor

Deee92 commented Sep 28, 2020

This was really useful @gluckzhang! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants