add coverage to circleci

[davidhyman]

probably don't merge just yet, let's see what circleci does, maybe add coveralls

[davidhyman]

Please could someone with admin rights on the circle build configure the following environment parameter:
COVERALLS_SERVICE_NAME=repo token

[screamerbg]

Can you push a fake commit? Restarting the job doesn't take into account new environment variables.

[screamerbg]

Still fails even though the environment variable. I'm looking at it as we speak.

On a side note, why not move coveralls in after_success section, so CI builds don't fail due to coveralls service issues? E.g.

after_success:
  - coveralls

[davidhyman]

yes lets do that once it's working 👍

[screamerbg]

@davidhyman CircleCI is reporting issue with:

$ coveralls

Submitting coverage to coveralls.io...
Coverage submitted!
Couldn't find a repository matching this job.
'url'

coveralls returned exit code 2

Before the error CircleCI reports Suppressing export of environment variables COVERALLS_REPO_TOKEN fork PR builds

Any idea?

[screamerbg]

Apparently there's an option in CircleCI which allows env vars to be exposed to the container. It's generally considered unsafe and turned off by default. I turned it on to check whether it would build successfully, though this doesn't seems like the way to go.

[coveralls]

Changes Unknown when pulling 10de503 on davidhyman:d/coverage_clean into ** on ARMmbed:master**.

[davidhyman]

Sorry for the delay; yes absolutely we should not use that feature! ⚠️

The risk is that any fork PR built could include code that exports the entire environment which, if it contains tokens for git or whatever, would be a Bad Thing. Hopefully there's no private keys there used for signing stuff, for example.

If you create a new native branch and move the PR onto it, that should work.

[coveralls]

Changes Unknown when pulling 10de503 on davidhyman:d/coverage_clean into ** on ARMmbed:master**.

[screamerbg]

@davidhyman How can we enable this?