Adding radiation quality control tests #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not require shortwave.
kenkehoe
requested review from
AdamTheisen,
zssherman and
mgrover1
as code owners
AdamTheisen
reviewed
Nov 6, 2024
act/qc/bsrn_tests.py
Outdated
| test_meaning=test_meaning, | ||
| ) | ||
|
|
||
| def k_test( |
There was a problem hiding this comment.
@kenkehoe since there's ktest in scipy and this one seems specific to bsrn QC, it might be beneficial to have a more descriptive name so users don't think this is a generic k-test like in scipy.
There was a problem hiding this comment.
OK good point. I will rename.
…able in numpy or other libraries.
AdamTheisen
approved these changes
Nov 6, 2024
|
@zssherman I'll let you review and merge in if you approve. Then I think we're good for another release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional quality control tests for radiation data. Uses the Best Practices Handbook for the Collection and Use of Solar Resource Data for Solar Energy Applications: Fourth Edition.