Updates to making QC Summary files #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Improved how history attribute is modified.
…py.datetime64. If not will convert to work with method to add DQR information.'
… info to history attribute. Removed command that updates orginal Dataset.
…) method to ensure the attribute removal takes hold.
…. Checking rm_assessments keyword.
…kips scalar qc variable.
kenkehoe
requested review from
AdamTheisen,
zssherman and
mgrover1
as code owners
|
@kenkehoe Thanks for the PR, I'll give this a review tomorrow |
zssherman
requested changes
Aug 29, 2024
zssherman
requested changes
Aug 30, 2024
|
@kenkehoe I made some changes etc, are you good with me merging this in? |
|
Yes, you can merge your changes. |
AdamTheisen
approved these changes
Sep 4, 2024
|
@zssherman this looks good to me. If all changes you requested have been implemented, I would say merge away! |
mgrover1
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some incremental updates to the method that creates a QC Summary. Also, working on improving the output netCDF file by improving how we correct the Dataset when writing to follow CF. Added some pytest.warn() to capture warnings and ensure they occur in our testing.