Allow DCaPST AmbientCO2 value to be read from weather component. #9524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joesaddigh
changed the title
|
Some simulations in the DCaPST validation file are set to run for years in the 1990s and 2000s. Is this change appropriate? Shouldn't a CO₂ setter be included in each of those simulations to set CO2 at the appropriate level? |
…ST. Default this to 420, but allow it to be overridden via the CO2 model value, that can be added to the weather.
…nts in the SorghumDCaPST simulation.
… test that was also forcing public method which should've been private.
Hi Brian. Thank you for your comment. It is a good point. We are looking at implementing a better solution that allows more flexibility than a hardcoded value. Once implemented and tested, I will provide some more information on this Bug report. Hope that's ok? |
….AmbientCO2" instead of "[Weather].CO2" as the XValue.
…n files. Revert Sorghum.json to use the original CO2Modifer.
joesaddigh
changed the title
|
This might be helpful: #9356. |
joesaddigh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9523
DCaPST currently uses a default value for the concentration of carbon dioxide (CO2) in the atmosphere, of 363ppm. This value is out of date. Rather than simply change the harcoded value to match the current value of 420ppm, DCaPST will be udpated to use the Weather.CO2 value. This Weather.CO2 can be set via the CO2Value component. DCaPST will now error if no CO2Value component has been added to the Weather component.