From 3d40f82460541649f194b09f4dc6ba7e9c1844fe Mon Sep 17 00:00:00 2001 From: Miki Date: Wed, 15 Nov 2023 15:35:09 -0800 Subject: [PATCH] Fix navigation bug from dashboard to dashboard (cherry picked from commit 1de8be6ad21ae0a056dbe62322b89ef7db610a48 from #5435) Also: * Lock chromedriver to v116 which is the last one compatible with Node 16 * Bump caniuse-lite db. Signed-off-by: Miki --- .github/workflows/build_and_test_workflow.yml | 16 +++++++-- package.json | 2 +- .../embeddable/dashboard_container.tsx | 1 + yarn.lock | 36 +++++++++---------- 4 files changed, 34 insertions(+), 21 deletions(-) diff --git a/.github/workflows/build_and_test_workflow.yml b/.github/workflows/build_and_test_workflow.yml index f4f5395ea2fd..69150ccf30ca 100644 --- a/.github/workflows/build_and_test_workflow.yml +++ b/.github/workflows/build_and_test_workflow.yml @@ -181,8 +181,20 @@ jobs: restore-keys: | yarn- - - name: Setup chromedriver - run: node scripts/upgrade_chromedriver.js + # Node 16 is only supported by ChromeDriver 116 and lower + - name: Download Chrome + id: download-chrome + uses: abhi1693/setup-browser@v0.3.5 + with: + browser: chrome + # https://chromiumdash.appspot.com/branches + version: 1160321 + + - name: Setup Chrome + run: | + sudo rm -rf /usr/bin/google-chrome + sudo rm -rf /opt/google/chrome/chrome + sudo ln -s ${{steps.download-chrome.outputs.path}}/${{steps.download-chrome.outputs.binary}} /usr/bin/google-chrome - name: Run bootstrap (Linux) if: matrix.os != 'windows-latest' diff --git a/package.json b/package.json index 587d9a29b5c6..47c2454aa956 100644 --- a/package.json +++ b/package.json @@ -358,7 +358,7 @@ "chai": "3.5.0", "chance": "1.0.18", "cheerio": "0.22.0", - "chromedriver": "^107.0.3", + "chromedriver": "^116.0.0", "classnames": "2.3.1", "compare-versions": "3.5.1", "d3": "3.5.17", diff --git a/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx b/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx index c87c3478558c..ca552eddaad1 100644 --- a/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx +++ b/src/plugins/dashboard/public/application/embeddable/dashboard_container.tsx @@ -235,6 +235,7 @@ export class DashboardContainer extends Container