Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ideal gas EOS with tabulated mean molecular weight #1488

Open
BenWibking opened this issue Feb 20, 2024 · 2 comments
Open

add ideal gas EOS with tabulated mean molecular weight #1488

BenWibking opened this issue Feb 20, 2024 · 2 comments

Comments

@BenWibking
Copy link
Collaborator

For many of our applications, we have an ideal gas but with a mean molecular weight that varies as a function of $(\rho, T)$. The temperature can be solved via root-finding on on a table of mean molecular weight.

We have this implemented in Quokka for our tabulated dilute plasma cooling, but it is not currently integrated with the EOS infrastructure. In the future, we should move this part of the code to Microphysics.

cc: @markkrumholz @aditivijayan

@BenWibking
Copy link
Collaborator Author

BenWibking commented Feb 20, 2024

@zingale What format would be appropriate to put this table in? We currently read this table from an HDF5 file, but HDF5 would then have to become a Microphysics dependency.

Our existing code to read this table is here:
https://github.com/quokka-astro/quokka/blob/6aca86475ce95a8e9cec545e01dfae1edd52639c/src/GrackleDataReader.cpp#L203

@zingale
Copy link
Member

zingale commented Feb 20, 2024

I think that HDF5 is fine as an optional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants