Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate the helmtable without needing std::log10 #1258

Open
zingale opened this issue Jul 5, 2023 · 1 comment
Open

regenerate the helmtable without needing std::log10 #1258

zingale opened this issue Jul 5, 2023 · 1 comment

Comments

@zingale
Copy link
Member

zingale commented Jul 5, 2023

One of the most expensive parts of the Helmholtz EOS (on GPUs) is taking the log to T, rho each time we need to find the index into the electron table. We should regenerate the table with a different spacing that doesn't require the log. Some ideas are contained in this paper:

https://arxiv.org/abs/2206.08957

and the code appears here:

https://github.com/lanl/singularity-eos/blob/2ea3957cc18cd4709b926f415dd68a8d4daf8821/singularity-eos/base/fast-math/logs.hpp#L38C3-L38C3

This will require us to write a standalone EOS that computes the F-D integrals to tabulate the electron-positron values. This would be nice to have in any case, because it would allow us to sync up the values of the fundamental constants.

@BenWibking
Copy link
Collaborator

BenWibking commented Jul 8, 2023

It might also be possible to replace all of these kinds of tabular interpolations with DNNs. In any case, it would be fun to try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants