Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch Strang integration to work with (rho X, rho e) #1200

Open
zingale opened this issue May 31, 2023 · 3 comments
Open

switch Strang integration to work with (rho X, rho e) #1200

zingale opened this issue May 31, 2023 · 3 comments

Comments

@zingale
Copy link
Member

zingale commented May 31, 2023

Right now Strang integrates (X, e) and SDC integrates (rho X, rho e). We should sync them.

algebraically, since rho is constant in Strang integration, this should not affect things much (except how atol is interpreted). But it will make code reuse between SDC and Strang much easier.

@zingale
Copy link
Member Author

zingale commented Jun 1, 2023

maybe the way to do this is to have the state always come in via burn_t burn_state.y[]. But for Strang we don't need to
include the momenta or the advective terms.

@maxpkatz
Copy link
Member

maxpkatz commented Jun 4, 2023

Seems to me like we should just aim to use the SDC integrator for Strang with the advective terms set to zero.

@zingale
Copy link
Member Author

zingale commented Jun 4, 2023

yes. I think that's a good idea. We can constexpr them out too

zingale pushed a commit that referenced this issue Jun 24, 2023
This is a first step in merging the integrator code paths for Strang and simplified SDC, as in #1200. For now these components will remain uninitialized and unused for Strang burns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants