Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up reaction source storage for true-SDC #2588

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Clean up reaction source storage for true-SDC #2588

merged 2 commits into from
Oct 2, 2023

Conversation

zingale
Copy link
Member

@zingale zingale commented Sep 28, 2023

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
clean up the true-SDC reaction source storage
9a26291 
we don't need the fluid state there
@zingale zingale changed the base branch from main to development September 28, 2023 15:33
@zingale zingale changed the title [WIP] Clean up reaction source storage for true-SDC Clean up reaction source storage for true-SDC Oct 1, 2023
@zingale zingale merged commit afcf69c into AMReX-Astro:development Oct 2, 2023
18 checks passed
@zingale zingale deleted the clean_up_rate_storage branch October 2, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpkatz maxpkatz maxpkatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maxpkatz