[deploy] Update release-helm-chart CI step

[Zoobdude]

The current version of actions/upload-artifact being used in the release-helm-chart CI step is v3 and will no longer work as of December 5, 2024.

Although I initially thought that the helm charts could be uploaded directly to gh pages, therefore removing the need for the separate release branch, I believe this would only make the latest release available as every time the action is run, the current gh pages deployment would be overwritten.

After looking at the key differences I think you might be able to just bump the version of this dep and continue using the current method?

The official method of distributing helm charts via gh pages seems to be using the helm chart releaser action (helm/chart-releaser-action) which still uses a separate branch.

However I do also see releasing to a container registry is also on the cards in #274. Which looks like it could be setup with GHCR with https://github.com/appany/helm-oci-chart-releaser

Which method(s) would you like me to implement? Or do you want to try bumping actions/upload-artifact to v4 first?

[Zoobdude]

I also have noticed many of the other actions dependencies are also on older, often deprecated versions. Have you considered enabling something like dependabot or Renovate? Potentially for the whole codebase or just for gh actions. @amrc-benmorrow

[amrc-benmorrow]

OK, that makes sense about losing the old releases; we can't really do that. I'm not really happy about the release branch containing completely different contents from the rest of the repo, but it's not important. This is more of an issue since we've moved ACS to a monorepo so it now contains much more than just the Helm chart.

I think bumping the version is probably the best course for now. I would like to move to OCI but we have to be a little cautious; we have internal deployments using Flux which we would have to confirm will accept an OCI chart without problems first.

Dependabot: you might be right. I'm not sure where the line is here between 'useful' and 'irritating' :). Chasing updates seems to break things a lot more than it should; too many NPM authors seem to have no clue what 'compatible' means.

[Zoobdude]

Resolved in #380