Support filters: IResultFilter for classic controllers and IEndpointFilter for minimalAPI #72
Labels
enhancement
New feature or request
Comments
|
After some preliminary research, the idea seems viable but has some downsides. Experiment public class ActionFilter : IActionFilter, IEndpointFilter
{
public void OnActionExecuted(ActionExecutedContext context)
{
var actionResult = (context.Result as ObjectResult)?.Value;
if (actionResult is IDomainResult result)
context.Result = result.ToActionResult();
// ... Other types are harder to handle
}
public async ValueTask<object?> InvokeAsync(EndpointFilterInvocationContext context, EndpointFilterDelegate next)
{
// See context here
return await next(context);
}
}which was registered globally for the classic API as services.AddSingleton<IActionFilter, ActionFilter>();
services.AddControllers(options => options.Filters.AddService<IActionFilter>());Downsides
[HttpGet("[action]")]
public IDomainResult<int> Get200OkWithNumber() => _service.GetSuccessWithNumericValue();
app.MapGet("200OkWithNumber", () => service.GetSuccessWithNumericValue())
.AddEndpointFilter<ResultFilter>()
Produces<int>();Notes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the API methods have to call
.ToActionResult()/.ToResult()extension methods for converting aDomainResulttoIActionResult/IResult.To avoid the repetitive calls of those methods, the MVC package can offer filters (
IResultFilterfor the classic controllers andIEndpointFilterfor the minimal API). So, if the returning type isDomainResultBaseorTask<DomainResultBase>', it would.ToActionResult()or.ToActionResultOfT()for the classic controllers;.ToResult()or.ToResultOfT()for the minimal API.Notes:
ToCustomActionResultOfT()is used, the filters wouldn't helpThe text was updated successfully, but these errors were encountered: