Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor fixes and improvements mostly related to SNP readers #13

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

salcc
Copy link
Member

@salcc salcc commented Nov 21, 2024

See the commit messages for details.

(the use of [] does not work on the terminal without '')
- Fix plink2 url in conftest and benchmark
- Add support for executing these scripts in macOS
- Put vcf files in vcf folder (like it is done with bed and pgen), and update appropriate paths in demos
- Rename test_phased.py to test_summed_strands.py, move the corresponding readers there and remove them from conftest, as they are not shared by other tests
@salcc salcc added the bug Something isn't working label Nov 21, 2024
Copy link
Member

@davidbonet davidbonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thanks!

@davidbonet davidbonet merged commit ffea32c into main Nov 22, 2024
6 checks passed
@davidbonet davidbonet deleted the fixes branch November 22, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants