Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filtering #11

Open
matthewcarbone opened this issue Apr 19, 2022 · 0 comments
Open

Implement filtering #11

matthewcarbone opened this issue Apr 19, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@matthewcarbone
Copy link
Contributor

Zhu's comment:

Filtering: this step essentially filters out “bad” spectra according to, and not limited to, the following criteria:
Noise. Filters out noise spectra (some noisy spectra might still be useful, but we need to talk to Eli after implementing this. Or an “averaging” step is also necessary).
Shape. Those spectra with some weird shape will be filtered out (this step is by far done by some human defined rule. A fully-connected network was also created to do the job, but I stopped improving it at some point, need to revisit it).

@zhul9311, can you elaborate a bit more on what exactly you mean here? Specifically.

  1. By filtering out bad spectra, do you mean just letting the user know that it's "bad" by some user-defined criteria?
  2. By filtering out spectra with weird shapes, what exactly do you mean? Can you be specific? Makes it easier to code it up.

Note as well, I don't know if this will fall under the category of the Operator class, but it might (perhaps it just returns None if the spectrum is bad, along with the appropriate metadata).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants