Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandeep Sharma added #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sandeepsharma-kgp
Copy link

Please review and add me
Sandeep Sharma sandeepsharma-kgp

@abinashmeher999
Copy link
Member

This looks good.

@@ -38,6 +38,7 @@ Lines starting with `*` are automatically rendered as bullet points and phrases
* Pranai Kumar[pranaikumar](http://github.com/pranaikumar)
* Priyank Palod [priyankpalod](https://github.com/priyankpalod)
* Rameshwar Bhaskaran [zorroblue](https://github.com/zorroblue)
* Sandeep Sharma[sandeepsharma-kgp](https://github.com/sandeepsharma-kgp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add a space after your name.

@abinashmeher999
Copy link
Member

You have added your changes to the master. That should not be done. Also this is a duplicate of your previous PR. In case you need to make extra changes, you modify them in your current PR. A new PR only causes confusion. I will suggest you to modify the history of your earlier PR and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants