diff --git a/.github/workflows/deploy_github.yml b/.github/workflows/deploy_github.yml index 80bb088..b56f5da 100644 --- a/.github/workflows/deploy_github.yml +++ b/.github/workflows/deploy_github.yml @@ -58,4 +58,4 @@ jobs: files: | ./build-recipes/dist/*.dmg ./build-recipes/dist/*.pkg - ./build-recipes/Output/*.exe +# ./build-recipes/Output/*.exe diff --git a/.github/workflows/deploy_github_signed_windows.yml b/.github/workflows/deploy_github_signed_windows.yml index fdbdc20..2849a58 100644 --- a/.github/workflows/deploy_github_signed_windows.yml +++ b/.github/workflows/deploy_github_signed_windows.yml @@ -47,9 +47,6 @@ jobs: shell: bash run: | rm ./build-recipes/dist/PyJibe/PyJibe.exe - echo ${{ toJSON('0.1.2') }} - echo "${{ env.RELEASE_VERSION }}" - echo '${{ env.RELEASE_VERSION }}' - name: Sign Windows executable uses: signpath/github-action-submit-signing-request@v1 with: @@ -89,11 +86,6 @@ jobs: output-artifact-directory: 'build-recipes/Output' parameters: | Version: "${{ env.RELEASE_VERSION }}" - - name: Rename windows installer to signed - shell: bash - run: | - pushd ./build-recipes/Output/ - for file in *.exe ; do mv $file ${file//PyJibe/PyJibe_signed} ; done - name: Release Assets uses: softprops/action-gh-release@v1 with: @@ -101,6 +93,4 @@ jobs: draft: true prerelease: false files: | - ./build-recipes/dist/*.dmg - ./build-recipes/dist/*.pkg ./build-recipes/Output/*.exe diff --git a/CHANGELOG b/CHANGELOG index bc99651..22084b2 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,6 @@ +0.15.9 + - build: fix installation directory + - build: disable unsigned installer 0.15.8 - docs: fix broken link to code signing 0.15.7 diff --git a/build-recipes/win_pyjibe.iss_dummy b/build-recipes/win_pyjibe.iss_dummy index c42ca66..b6fa895 100644 --- a/build-recipes/win_pyjibe.iss_dummy +++ b/build-recipes/win_pyjibe.iss_dummy @@ -21,7 +21,7 @@ AppPublisher={#MyAppPublisher} AppPublisherURL={#MyAppURL} AppSupportURL={#MyAppURL} AppUpdatesURL={#MyAppURL} -DefaultDirName={localappdata}\{#MyAppPublisher}{#MyAppName} +DefaultDirName={autopf}\{#MyAppName} DisableDirPage=yes UsePreviousAppDir=false DefaultGroupName={#MyAppName} @@ -31,7 +31,8 @@ Compression=lzma SolidCompression=yes ChangesAssociations=yes PrivilegesRequired=lowest - +PrivilegesRequiredOverridesAllowed=dialog +WizardStyle=modern [Registry] Root: HKCU; Subkey: ".jpk-force"; ValueType: string; ValueName: ""; ValueData: "{#MyAppName}"; Flags: uninsdeletevalue diff --git a/docs/sec_code_signing.rst b/docs/sec_code_signing.rst index c56f841..10b69ae 100644 --- a/docs/sec_code_signing.rst +++ b/docs/sec_code_signing.rst @@ -3,9 +3,7 @@ Code Signing Policy PyJibe uses free code signing provided by `SignPath.io `_, certificate by `SignPath Foundation `_. These binaries -are named `PyJibe_signed` on the `release page `_. -You should prefer downloading these signed binaries for a smooth installation -process and an uninterrupted user experience. +can be downloaded from the `release page `_. Project Integrity diff --git a/pyjibe/head/update.py b/pyjibe/head/update.py index bd1b601..0945e31 100644 --- a/pyjibe/head/update.py +++ b/pyjibe/head/update.py @@ -66,11 +66,7 @@ def check_release(ghrepo="user/repo", version=None, timeout=20): if hasattr(sys, "frozen"): # determine which binary URL we need if sys.platform == "win32": - nbit = 8 * struct.calcsize("P") - if nbit == 32: - dlid = "win_32bit_setup.exe" - else: - dlid = "win_64bit_setup.exe" + dlid = "win_64bit_setup.exe" elif sys.platform == "darwin": dlid = ".pkg" else: