Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_vectors_candidate_points() v find_next_best_point() #953

Open
ns-rse opened this issue Oct 15, 2024 · 0 comments
Open

check_vectors_candidate_points() v find_next_best_point() #953

ns-rse opened this issue Oct 15, 2024 · 0 comments
Labels
DNATracing Issues pertaining to the DNATracing class
Milestone
M4 : On-going Ref...

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Oct 15, 2024

Whilst working on #948 I noticed that in some places check_vectors_candidate_points (nee checkVectorsCandidatePoints) was commented out (lines 83 and 187) in favour of using find_next_best_point (nee findNextBestPoint) but check_vectors_candidate_points is still used in some places.

  • Is this deliberate?
  • Can or should find_next_best_point replace all calls made to check_vectors_candidate_points?

If we can remove old legacy code we should it only serves to confuse our future selves and others.
@ns-rse ns-rse added the DNATracing Issues pertaining to the DNATracing class label Oct 15, 2024
@ns-rse ns-rse mentioned this issue Oct 15, 2024
Merged
@ns-rse ns-rse changed the title check_vectors_candidate_points() v find_nex_best_point() check_vectors_candidate_points() v find_next_best_point() Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DNATracing Issues pertaining to the DNATracing class
Projects
None yet
Milestone
M4 : On-going Refactoring
Development

No branches or pull requests
1 participant
@ns-rse