Add mypy to pre-commit and improve typehints #98
+55
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- increase `max-positional-arguments=6`` - `logging-format-style=new` - `logging-modules=loguru`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 65.87% 72.00% +6.13%
==========================================
Files 3 8 +5
Lines 337 593 +256
==========================================
+ Hits 222 427 +205
- Misses 115 166 +51 ☔ View full report in Codecov by Sentry. |
ns-rse
force-pushed
the
ns-rse/96-mypy-ci
branch
from
3d10c16 to
5baa961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
Adds mypy checks to pre-commit hooks.
Used RightTyper to help identify errors and the correct types, it was useful but not comprehensive as mypy still threw a lot of problems which have, mostly, been corrected. This was mainly as a precurrsor to addressing and correcting type hints in TopoStats.
There were a few areas where ignores have been added as I couldn't see how to correct these. They may want correcting in the modules, less important for the tests.