Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently raise FileNotFound errors across each load_*() functions. #80

Open
ns-rse opened this issue Dec 2, 2024 · 0 comments
Open

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Dec 2, 2024

In the recent v0.0.2 release the raising of errors if files do not exist at the given location /can not be found isn't quite consistent across the supported filetypes.

File Extension Raises FileNotFound error
.spm
.jpk
.ibw
.gwy
asd.py

ibw.py

The load_ibw() function does have an explicit exception check for FileNotFound but within this there is no raise to ensure the error is raised when encountered. Instead it progresses and we observe an UnboundLocalError.

asd.py

The load_asd() function does not currently have an explicit except/raise for FileNotFound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant