Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt-data-type-definitions.json: Add Biochar as a CropNutrientIngredient #157

Open
dubnemo opened this issue Dec 5, 2024 · 1 comment

Comments

@dubnemo
Copy link
Collaborator

dubnemo commented Dec 5, 2024

Are we limited to elements on the Periodic Table?

I'd like to suggest a set of organic fertilizers, such as biochar and the classic manure.

@dubnemo dubnemo changed the title adapt-data-type-definitions.json: Add Biochar as a CropNutrientIngredient to adapt-data-type-definitions.json: Add Biochar as a CropNutrientIngredient Dec 5, 2024
@knelson-farmbeltnorth
Copy link
Contributor

@dubnemo We brought in that list from what was in the ADAPT Framework. I can't say what it's history is, but I always understood it to be a list of discrete active ingredients in chemical fertilizers. We can revise that list just as we are doing with OperationType.

My concern would be that it represent a list of separate nutrients one would find on a chemical analysis of either organic or synthetic fertilizer. If it is a higher level concept, representing a category of fertilizer vs. chemical composition, perhaps we need a new attribute on the object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants